chore(helm): remove unused and redundant field from compactor.persistance values.yaml #19443
+7
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compactor.persistance.size and compactor.persistance.storageClass is not being used in template and is confusing . as both of these are configured inside claims Signed-off-by: Vishwanath Bhat <[email protected]>
|
|
|
Agree, I see any usage. https://github.com/search?q=repo%3Agrafana%2Floki%20%22compactor.persistance%22&type=code |
|
LGTM |
|
@Vishwanath2001 please add a note to the CHANGELOG. |
Signed-off-by: Vishwanath Bhat <[email protected]>
|
Have added the entry in CHANGELOG @jkroepke |
Signed-off-by: J Stickler <[email protected]>
|
@Vishwanath2001 please run make helm-docs as well. |
|
Done @jkroepke |
Signed-off-by: Vishwanath Bhat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compactor.persistance.size and
compactor.persistance.storageClass
is not being used in template and is confusing .
as both of these are configured inside claims
What this PR does / why we need it:
Removes unused field from default values file / It is causing confusion about where to configure pvc size for compactor
Which issue(s) this PR fixes:
Trivial fix , no issue created